download compression is too slow #727
Merged
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and reduce logging noise from data version checker
Tests on a medium-sized data set (3552 sequences): I measured request times of /sample/unalignedNucleotideSequences: - uncompressed: 1300 ms, 65 MB - gzip compressed: 3100 ms (before: 14 s), 8 MB - zstd compressed: 970 ms (before: 7.4 s), 342 kB
chaoran-chen
reviewed
Apr 3, 2024
Comment on lines
+225
to
+235
| override fun write(bytes: ByteArray) { | ||
| compressingStream.write(bytes) | ||
| } | ||
|
|
||
| override fun write( | ||
| bytes: ByteArray, | ||
| offset: Int, | ||
| length: Int, | ||
| ) { | ||
| compressingStream.write(bytes, offset, length) | ||
| } |
There was a problem hiding this comment.
@chaoran-chen Those are the relevant changes. We didn't forward those methods to the compressing stream. Instead, the default implementation would call fun write(byte: Int) for every entry of the ByteArray. Apparently the compression streams can do a lot better than writing every byte individually.
JonasKellerer
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #717
Tests on a medium-sized data set (3552 sequences):
I measured request times of /sample/unalignedNucleotideSequences:
I tested this using the Ebola dataset from Loculus. I pushed it to a branch: https://github.com/GenSpectrum/LAPIS/tree/ebolaTestData
PR Checklist
[ ] All necessary documentation has been adapted.[ ] The implemented feature is covered by an appropriate test.